smb: enable for macOS / iOS builds & fix some libretro-common include usage#18652
smb: enable for macOS / iOS builds & fix some libretro-common include usage#18652cscd98 wants to merge 1 commit intolibretro:masterfrom
Conversation
cscd98
force-pushed
the
libsmb2-apple
branch
2 times, most recently
from
1d4f970 to
6f817f1
Compare
cscd98
changed the title
cscd98
force-pushed
the
libsmb2-apple
branch
3 times, most recently
from
fcc8056 to
7d2f439
Compare
cscd98
changed the title
cscd98
force-pushed
the
libsmb2-apple
branch
4 times, most recently
from
b8304e3 to
867d60c
Compare
|
@warmenhoven Any chance you can review this as the libretro-common updates need to get in. @joaodforce has (I think if its the same person on discord) tested this on apple devices 👍 |
|
I haven't had a chance to test out the Apple changes myself yet but did review the libretro-common change and that is good so I've cherry picked that to master, so the only thing remaining is the Apple specific bits. |
|
I have been looking at this and experimenting with it, and honestly I've been going back and forth between this PR and just including it in retroarch-apple-deps. In the end I've decided to go with retroarch-apple-deps. I think having it in RetroArch/deps and griffin.c is important for some platforms, but it makes it easier for everyone if they don't have to worry about all the platforms that might get broken from any given library update. (I also moved Apple to using mbed-tls from retroarch-apple-deps instead of the builtin one for similar reasons.) |
2 participants
Guidelines
Description
Now that libsmb2 is in griffin, we can use it for apple builds.
Its been added to baseconfig and RetroArch project files. This work is untested as I do not own a macbook.
Makes it more portable for libretro-common
Related Issues
Related Pull Requests
Reviewers
@warmenhoven